Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stylelint fixup #6776

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Jul 4, 2022

Alternative to #6774, if it works 馃馃徎

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change) and are in the imperative mood. Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadoc, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO") if applicable.
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@NotMyFault NotMyFault added skip-changelog Should not be shown in the changelog alternative This PR is one of several options to address a given issue labels Jul 4, 2022
@NotMyFault NotMyFault requested a review from basil July 4, 2022 20:16
@NotMyFault
Copy link
Member Author

The build log on https://ci.jenkins.io/job/Core/job/jenkins/job/PR-6776/1/consoleFull is clean of errors in regards of stylelint so far

@NotMyFault NotMyFault mentioned this pull request Jul 4, 2022
12 tasks
@NotMyFault NotMyFault requested a review from a team July 4, 2022 22:17
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invoking the de minimis clause.

@basil basil merged commit 8833407 into jenkinsci:master Jul 5, 2022
@NotMyFault NotMyFault deleted the fix/master/stylelint-fixup branch July 5, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alternative This PR is one of several options to address a given issue skip-changelog Should not be shown in the changelog
Projects
None yet
2 participants