Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating Functions.singletonList #6740

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 1, 2022

See #6732 (comment).

Proposed changelog entries

  • Deprecating Functions.singletonList which is not normally needed in JEXL.

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@jglick jglick added the developer Changes which impact plugin developers label Jul 1, 2022
* (which may be usable where a {@link List} is expected)
* rather than {@code h.singletonList(obj)}.
*/
@Deprecated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it would matter. It could be considered retroactively deprecated since the beginning of the Hudson project. Anyway the call sites are in Jelly sources where no IDE will be able to display this information.

@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 2, 2022
@timja
Copy link
Member

timja commented Jul 2, 2022

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@timja timja merged commit adda175 into jenkinsci:master Jul 6, 2022
@jglick jglick deleted the singletonList branch July 6, 2022 12:54
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Sep 28, 2022

I believe that the emailext-template-plugin groovy UI script that calls h.singletonList(it) needs to be changed in order to fix JENKINS-69153. jenkinsci/emailext-template-plugin#71 has been submitted to the plugin with a proposed fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
4 participants