-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating Functions.singletonList
#6740
Conversation
* (which may be usable where a {@link List} is expected) | ||
* rather than {@code h.singletonList(obj)}. | ||
*/ | ||
@Deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why it would matter. It could be considered retroactively deprecated since the beginning of the Hudson project. Anyway the call sites are in Jelly sources where no IDE will be able to display this information.
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
I believe that the emailext-template-plugin groovy UI script that calls |
See #6732 (comment).
Proposed changelog entries
Functions.singletonList
which is not normally needed in JEXL.Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are accurate, human-readable, and in the imperative moodupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).