-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stylelint fixes #5006
Stylelint fixes #5006
Conversation
conflicts |
Merged with master, there are currently failing frontend tests in master:
|
weird, this seems to fix it: #5031 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice when I look at the logs i see almost a third of it is just stylelint warnings. Hopefully we can have that cleaned up
The plan is definitly to get rid of all these. I just wanted to keep the changes "reviewable" |
I fixed a couple of stylelint warnings to reduce the amount of warnings.
selector-list-comma-newline-after
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).