Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint fixes #5006

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Stylelint fixes #5006

merged 3 commits into from
Oct 29, 2020

Conversation

StefanSpieker
Copy link
Contributor

I fixed a couple of stylelint warnings to reduce the amount of warnings.

  • merged duplicate selectors
  • Added a couple of newlines because of rule selector-list-comma-newline-after

Proposed changelog entries

  • Internal: N/A

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@timja timja added internal skip-changelog Should not be shown in the changelog labels Oct 18, 2020
@timja
Copy link
Member

timja commented Oct 23, 2020

conflicts

@StefanSpieker
Copy link
Contributor Author

Merged with master, there are currently failing frontend tests in master:

[INFO] Test Suites: 1 failed, 2 passed, 3 total
[INFO] Tests:       6 failed, 14 passed, 20 total

@timja
Copy link
Member

timja commented Oct 25, 2020

Merged with master, there are currently failing frontend tests in master:

[INFO] Test Suites: 1 failed, 2 passed, 3 total
[INFO] Tests:       6 failed, 14 passed, 20 total

weird, this seems to fix it: #5031
but not sure what caused it and for it not to be picked up in CI

Copy link
Contributor

@res0nance res0nance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice when I look at the logs i see almost a third of it is just stylelint warnings. Hopefully we can have that cleaned up

@res0nance res0nance added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 27, 2020
@StefanSpieker
Copy link
Contributor Author

The plan is definitly to get rid of all these. I just wanted to keep the changes "reviewable"

@timja
Copy link
Member

timja commented Oct 27, 2020

Looks like a flakey test:
image

@res0nance res0nance merged commit b710b8a into jenkinsci:master Oct 29, 2020
@StefanSpieker StefanSpieker deleted the stylelint_fixes branch October 29, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
3 participants