Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-46082] API will include culprits again. #2978

Merged
merged 1 commit into from Aug 12, 2017

Conversation

abayer
Copy link
Member

@abayer abayer commented Aug 11, 2017

See JENKINS-46082.

Proposed changelog entries

  • Entry 1: JENKINS-46082, XML and JSON API will include culprits (regression in 2.60).

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@reviewbybees

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 In longer term we also need a fix in Stapler

@ghost
Copy link

ghost commented Aug 11, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@abayer
Copy link
Member Author

abayer commented Aug 11, 2017

@oleg-nenashev Agreed, but this didn't seem like worth waiting.

@oleg-nenashev
Copy link
Member

I agree. If nobody votes against, will merge it into the next weekly to get soaked for the next x.1 LTS

@daniel-beck
Copy link
Member

Is this expected to be resolved in Stapler any time soon? AFAIUI that's a Java 8 specific limitation of that...?

@oleg-nenashev
Copy link
Member

@abayer could you please create a ticket to Stapler?

@abayer
Copy link
Member Author

abayer commented Aug 11, 2017

@oleg-nenashev What component etc do I use?

@oleg-nenashev
Copy link
Member

@abayer https://github.com/stapler/stapler/issues + Mirror issue to core

@abayer
Copy link
Member Author

abayer commented Aug 11, 2017

jenkinsci/stapler#126

@abayer
Copy link
Member Author

abayer commented Aug 11, 2017

@oleg-nenashev
Copy link
Member

@reviewbybees done

@jenkinsci/code-reviewers I kindly ask for the expedited review since it is a regression.

@oleg-nenashev oleg-nenashev merged commit ee3600c into jenkinsci:master Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants