Add BuildWatcher support to RealJenkinsRule
#519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling rjr.watchBuilds() will register BuildWatcher and print build logs.
Vlatombe
commented
Nov 18, 2022
Comment on lines
+878
to
+880
| if (buildWatcher != null) { | ||
| buildWatcher.after(); | ||
| } |
There was a problem hiding this comment.
Probably not strictly necessary since the jvm will shutdown just after.
Vlatombe
changed the title
BuildWatcher support to RealJenkinsRule
jglick
reviewed
Nov 18, 2022
There was a problem hiding this comment.
OK but there is actually a better way which does not require anything to run inside the controller JVM and is more flexible. BuildWatcher as currently designed does not handle the case that the build is already running when the controller starts (or, in this case, when the Surefire JVM connects to it). That means it does not support @LocalData, and it only supports watching builds across JenkinsSessionRule restarts insofar as the JVM does not exit. I have a plan to write this up properly and support RJR. Not sure if this patch would conflict with that.
|
Superceded by #532 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
rjr.watchBuilds()will register BuildWatcher and print build logs.Result can be observed by running
mvn test -Dtest=RealJenkinsRuleTest#agentBuild