Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify new semantic of #getUrl #475

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Clarify new semantic of #getUrl #475

merged 1 commit into from
Aug 16, 2022

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Aug 16, 2022 •
edited

Amends #348, as it broke semantic of #getUrl which now must be called
after starting Jenkins.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe
Clarify new semantic of #getUrl
590098e 
Amends jenkinsci#348, as it broke semantic of #getUrl which now must be called
after starting Jenkins.
@Vlatombe Vlatombe added the bug label Aug 16, 2022
@Vlatombe Vlatombe requested a review from jglick August 16, 2022 09:23
@basil basil merged commit 0ac4afc into jenkinsci:master Aug 16, 2022
@basil basil mentioned this pull request Aug 16, 2022
Closed
@Vlatombe Vlatombe deleted the getUrl-fix branch September 2, 2022 09:26
Vlatombe added a commit to Vlatombe/saml-plugin that referenced this pull request Sep 2, 2022
@Vlatombe
Fix LiveTest
b833190 
Since jenkinsci/jenkins-test-harness#475 & jenkinsci/jenkins-test-harness#348, you need to call RealJenkinsRule#getUrl after starting Jenkins.
@Vlatombe Vlatombe mentioned this pull request Sep 2, 2022
Merged
2 tasks
kuisathaverat pushed a commit to jenkinsci/saml-plugin that referenced this pull request Sep 2, 2022
@Vlatombe
Fix LiveTest (#264)
b722786 
Since jenkinsci/jenkins-test-harness#475 & jenkinsci/jenkins-test-harness#348, you need to call RealJenkinsRule#getUrl after starting Jenkins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

@timja timja timja approved these changes

@jglick jglick Awaiting requested review from jglick

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Vlatombe @basil @timja