Adding TailLog as an alternative to BuildWatcher
#532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vlatombe
approved these changes
Dec 2, 2022
timja
approved these changes
Dec 2, 2022
6 tasks
jglick
commented
Feb 13, 2023
|
|
||
| @Override | ||
| public void close() { | ||
| tailer.stop(); |
There was a problem hiding this comment.
jenkinsci/mock-slave-plugin@43ec9c7 from jenkinsci/mock-slave-plugin#165 might also need to wait for the tailer thread to exit, which I guess would mean manually starting the thread (not using create) and calling join.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#519 (review)