update relablings for servicemonitor resource #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmytro Lukianchikov <dimon.xr@gmail.com>
Signed-off-by: Dmytro Lukianchikov <dimon.xr@gmail.com>
dmitriy-lukyanchikov
force-pushed
the
fix-relablings-for-servicemonitor
branch
from
f968fd9
to
12cf2f6
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
stale
bot
added
the
lifecycle/stale
|
What would be required for this PR to be merged? |
stale
bot
removed
the
lifecycle/stale
|
A unit test and conflicts resolving, apologies for missing this PR |
|
Hi @dmitriy-lukyanchikov , was curious on the status on this PR. Would love to see this merged, let me know if I could help out. |
|
this looks like to be fixed on main branch, so can you close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
fix relabelings for servicemonitor, added toyaml because its a list of maps not the single value
Which issue this PR fixes
Special notes for your reviewer
Checklist