Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding if Condition for checksum #1079

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

vemulaanvesh
Copy link

@vemulaanvesh vemulaanvesh commented Apr 24, 2024

What does this PR do?

  • Adding a provision to turn off or on checksum
  • When i am applying JCASC via GH PR, every time when PR get merged, Jenkins is througing 111 error for nearly 30-40 sec (which means downtime for 30-40 sec).

  • so we want to turn off checksum and restart jenkins during maintaince window.

  • As this is a extra provision to users i feel this should be a good option

If you modified files in the ./charts/jenkins/ directory, please also include the following:

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. I bumped the "version" key in ./charts/jenkins/Chart.yaml.
    Options
  2. I added a new changelog entry to ./charts/jenkins/CHANGELOG.md.
    Options
  3. I followed the technical requirements.
    Options
  4. I ran .github/helm-docs.sh from the project root.
    Options

Special notes for your reviewer

Comment on lines 441 to 446
# -- Map of groovy init scripts to be executed during Jenkins controller start

# Enable or Disable checksum if we don't want to auto run configmaps
checksum: true

initScripts: {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You put this right in between the Helm docs for initScripts and the initScripts property itself. Also, for it to be compatible with Helm docs, your comment should start with --.

Suggested change
# -- Map of groovy init scripts to be executed during Jenkins controller start
# Enable or Disable checksum if we don't want to auto run configmaps
checksum: true
initScripts: {}
# -- Enable or Disable checksum if we don't want to auto run configmaps
checksum: true
# -- Map of groovy init scripts to be executed during Jenkins controller start
initScripts: {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants