-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to use jcasc test harness #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this seems reasonable to me.
@@ -44,6 +44,11 @@ | |||
<artifactId>structs</artifactId> | |||
<version>1.19</version> | |||
</dependency> | |||
<dependency> | |||
<groupId>org.jenkins-ci.plugins</groupId> | |||
<artifactId>jackson2-api</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious as to why a new dependency needs to be introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github-api-plugin depends on this plugin, so it's not really adding a new dep, but the released version is very out-dated (causing enforcer errors).
If someone wants to release github-api-plugin then this dependency change is unneeded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jenkinsci/github-api-plugin#35 is going to remove this dependency. Hopefully that gets released and you can just depend on the new version. @bitwiseman are you planning a new release soon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, there shouldn't be a conflict anymore and then this dependency could be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@res0nance
I'm planning to release as soon as I reasonably can, in the meanwhile. I'll take this PR as it stands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want this as of #269 anyway.
JCasc had to create a new dependency that wasn't a
tests
classifier because maven doesn't allow you to bring dependencies through classifiers.Upgrading here so that PCT works again,
Tracking:
jenkinsci/bom#164
Note: We'll need a release for PCT please