Revise static code analysis configurations (#152)

* Bump maven-checkstyle-plugin from 3.1.0 to 3.1.1

- closes #150

* Update xds references in configuration files

- update changed checkstyle modules

* Convert internal pipeline to declarative form

* Remove copyright header

* Remove copyright header

* Revise POM configuration regarding updated static code analysis

- update rules of static code analysis configurations
- use properties for CheckStyle configuration
- fail the build for all violations in analysis results
- use prepared dependencies for PMD check
- add contributor, issue and CI management section
- add fast profile without validation steps

* Sync IDEA settings with static code analysis configurations

- extend editorconfig with all IDEA specific settings

* Share IDEA run configurations

* CheckStyle: Fix JavadocParagraph violations

- remove @author tag to prevent parse error
- details: no viable alternative at input '<christian.poenisch@' while parsing HTML_ELEMENT

* CheckStyle: Fix FinalParameters

* CheckStyle: Fix SummaryJavadoc

* CheckStyle: Fix FinalLocalVariable

* CheckStyle: Fix JavaDocMethod and MissingJavadocMethod

* CheckStyle: Remove HiddenField module

* CheckStyle: Remove ReturnCount module

* CheckStyle: Fix JavadocParagraph

* CheckStyle: Fix SeparatorWrap

* CheckStyle: Fix several minor violations

* CheckStyle: Fix OperatorWrap, DeclarationOrder, OverloadMethodsDeclarationOrder

- enable SuppressWarningsFilter

* PMD: Fix violations

* CheckStyle: Fix Indentation

* CheckStyle: Fix OperatorWrap

* CheckStyle: Remove NoClone module

* CheckStyle: Fix NoFinalizer, ParameterAssignment, IllegalCatch

* Enable to scan resources for CheckStyle violations

- set UTF-8 encoding for the whole project

* CheckStyle: Fix properties files

* Fix CasC IT for TEST-GUIDE installation

* Fix several found issues of IDEA analysis inspection results

- unnecessary throws, suppress warnings
- public inner static classes
- generic types
- unused return types

* SpotBugs: Fix or suppress all warnings

- use prepared statements for SQL queries
- fix inner serializable classes
- suppress transient field warnings

* Enable CheckStyle and PMD by default

- ignore all generated and test sources for CheckStyle

* Cache Maven dependencies for GitHub CI workflow

- change to verify goal to include static code analysis
- limit to PRs to master

* Fix synchronizing ATX default settings

* Fix overriding ATX settings from pipeline

* Fix showing ATX settings groups

- revise tests

* Fix redundant NP checks

* Avoid NP check for applicable ATX custom settings

* Ignore NP checks for all Launcher.getChannel() calls

* Ignore false positive NP checks in try-with-resources

- see: spotbugs/spotbugs#259

* Move ToolVersion to util package

* Set default value for usePersistedSettings checkbox

.github/workflows/maven.yml

@@ -5,14 +5,16 @@ on:
     branches:
       - master
   pull_request:
+    branches:
+      - master
 
 jobs:
   build:
     name: Build on Jenkins ${{ matrix.jenkins-version }}, JDK ${{ matrix.java }} and ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        java: [1.8, 11]
+        java: [8, 11]
         jenkins-version: [2.60.3, 2.176.4]
         os: [ubuntu-latest, windows-latest]
         include:
@@ -22,10 +24,18 @@ jobs:
           - java: '11'
             jenkins-version: '2.60.3'
     steps:
-      - uses: actions/checkout@v1
+      - name: Checkout
+        uses: actions/checkout@v1
       - name: Set up JDK ${{ matrix.java }}
         uses: actions/setup-java@v1
         with:
           java-version: ${{ matrix.java }}
+      - name: Cache dependencies
+        uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven
       - name: Build with Maven
-        run: mvn package -B -V --no-transfer-progress ${{ matrix.flags }}
+        run: mvn clean verify -B -V --no-transfer-progress ${{ matrix.flags }}