AutoScalingGroup Weight support #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking a shot at this! afaik you can ignore that warning (related post), it shouldn't affect the results of the tests |
haugenj
requested changes
Oct 6, 2021
There was a problem hiding this comment.
can you also remove the disclaimer from the instance weighting help blub?
src/test/java/com/amazon/jenkins/ec2fleet/fleet/AutoScalingGroupFleetTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/jenkins/ec2fleet/fleet/AutoScalingGroupFleetTest.java
Outdated
Show resolved
Hide resolved
Done! |
|
Any ETA on this one? |
haugenj
reviewed
Oct 11, 2021
src/test/java/com/amazon/jenkins/ec2fleet/fleet/AutoScalingGroupFleetTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/jenkins/ec2fleet/fleet/AutoScalingGroupFleetTest.java
Outdated
Show resolved
Hide resolved
|
👋 Sorry for the delay, I was hoping the failing windows tests were some sort of transient error but after rerunning a few times it seems like it's something else. I'd like to figure that out before we merge this |
|
@haugenj , something is wrong with the Windows Machine |
|
Any ETA on releasing this? |
|
I'll try and cut a release later today, or early tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186
Having some issues running the tests locally, can someone give me a hand in this?
Using Temurin SDK 1.8