Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Release Drafter app in favor of GitHub workflow #95

Merged

Conversation

NotMyFault
Copy link
Member

馃 Beep boop!

This is an automatic pull request that sets up release drafter as GitHub action for your repository.
Currently, you're using the app version of release drafter, which is deprecated since 2019.

Switching to the action is a drop in replacement and requires no further work from your side.
Once you merge this PR, the action is setup. If you want to configure it further, read here.

In case of questions, please ping @NotMyFault.

Additional information:

@jglick jglick added the chore label Mar 16, 2022
@jglick jglick requested a review from car-roll March 16, 2022 12:28
@car-roll
Copy link

Do we need to clean up .github/release-drafter.yml as well?
i.e remove this line?

tag-template: docker-commons-$NEXT_MINOR_VERSION

@NotMyFault
Copy link
Member Author

Do we need to clean up .github/release-drafter.yml as well? i.e remove this line?

tag-template: docker-commons-$NEXT_MINOR_VERSION

Not necessarily, adding the workflow file solely makes sure that the GitHub action is used in the future, if the app is uninstalled.
It honors the provided configuration in the same way like the app does.

However, if this repository opts in using CD, I'd remove it alongside the workflow, because the CD workflow handles that part.

@car-roll
Copy link

ping @rsandell for review as I do not have any permissions in this repo

@rsandell rsandell merged commit 1c3113f into jenkinsci:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants