Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize POM #140

Closed
wants to merge 3 commits into from
Closed

Modernize POM #140

wants to merge 3 commits into from

Conversation

offa
Copy link
Contributor

@offa offa commented Sep 6, 2022

Some POM modernizations:

  • Parent POM update
  • BOM update
  • Move description to index.jelly
  • Remove deprecated java.level
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@basil basil mentioned this pull request Dec 10, 2022
Merged
@basil
Copy link
Member

basil commented Dec 12, 2022

Suggest closing in favor of #159.

@offa
Copy link
Contributor Author

offa commented Dec 12, 2022

Indeed, thanks @basil

@offa offa closed this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@offa @basil