Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jcasc test harness #133

Merged
merged 2 commits into from Jan 14, 2020
Merged

fix jcasc test harness #133

merged 2 commits into from Jan 14, 2020

Conversation

jetersen
Copy link
Member

No description provided.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(once merged with a fixed subsumed PR)

@jglick
Copy link
Member

jglick commented Jan 14, 2020

needs merge

@jvz
Copy link
Member

jvz commented Jan 14, 2020

Is this waiting on anything else before merging?

@jetersen
Copy link
Member Author

there @jvz hopefully once it is green, we are good to go :D

@jvz
Copy link
Member

jvz commented Jan 14, 2020

Got a strange test failure that may or may not be relevant.

@jetersen
Copy link
Member Author

unrelated it also happened on the other PR

@jetersen jetersen closed this Jan 14, 2020
@jetersen jetersen reopened this Jan 14, 2020
@jvz jvz merged commit 4e20d62 into jenkinsci:master Jan 14, 2020
@jvz
Copy link
Member

jvz commented Jan 14, 2020

Thanks for the PR!

@jglick
Copy link
Member

jglick commented Jan 14, 2020

@jvz note that we are going to need a release of this: jenkinsci/bom#164 (comment)

@jvz
Copy link
Member

jvz commented Jan 14, 2020

Making one right now.

@jvz
Copy link
Member

jvz commented Jan 14, 2020

Released as 2.3.1.

@jetersen jetersen deleted the fix/jcasc-test-harness branch January 15, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants