Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Action CI as a backup CI instance #986

Merged
merged 9 commits into from Sep 12, 2019
Merged

Add GitHub Action CI as a backup CI instance #986

merged 9 commits into from Sep 12, 2019

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Aug 16, 2019 •
edited

Adds GitHub Action CI 馃憤 Once GitHub action is available for jenkinsci org We can introduce even more workflows.

Your checklist for this pull request

馃毃 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

@jetersen
Copy link
Member Author

jetersen commented Aug 16, 2019 •
edited

Current runs here: https://github.com/casz/configuration-as-code-plugin/runs/194970804

@jetersen
Copy link
Member Author

Windows CI is possible but would need to either create a vault image for Windows containers or skip Vault tests on Windows.

oleg-nenashev
oleg-nenashev approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although ci.jenkins.io is fixed right now, I do not want to block this change if other maintainers want to do it

plugin/src/test/java/io/jenkins/plugins/casc/vault/VaultTestUtil.java Outdated Show resolved Hide resolved
@oleg-nenashev oleg-nenashev changed the title Add GitHub Action CI Add GitHub Action CI as a backup CI instance Aug 16, 2019
@oleg-nenashev oleg-nenashev added the chore a PR that adds to maintenance - used by Release Drafter label Aug 16, 2019
@oleg-nenashev
Copy link
Member

Ship it?

@jetersen
Copy link
Member Author

馃憤

@jetersen jetersen changed the title Add GitHub Action CI as a backup CI instance 馃毀 Add GitHub Action CI as a backup CI instance Aug 26, 2019
@jetersen
Copy link
Member Author

jetersen commented Sep 8, 2019

heck ya https://github.com/casz/configuration-as-code-plugin/runs/215770844 馃挭

@jetersen jetersen changed the title 馃毀 Add GitHub Action CI as a backup CI instance Add GitHub Action CI as a backup CI instance Sep 8, 2019
@jetersen jetersen merged commit da737fe into jenkinsci:master Sep 12, 2019
@jetersen jetersen deleted the actionCI branch September 12, 2019 15:40
@oleg-nenashev
Copy link
Member

I requested participation in the Beta for the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick left review comments

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
chore a PR that adds to maintenance - used by Release Drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jetersen @oleg-nenashev @jglick @timja