upgrade to jcasc test harness

[jetersen]

JCasc had to create a new dependency that wasn't a tests classifier because maven doesn't allow you to bring dependencies through classifiers.

Upgrading here so that PCT works again,

Tracking:
jenkinsci/bom#164

Note: We'll need a release for PCT please

[jglick]

(once tests pass)

[imod]

@Casz tests failed :(

[jetersen]

Let's try bumping the maven plugin 🤔 wagon was updated in newer releases

[jetersen]

@imod

What is this used for?

        <dependency>
            <groupId>com.google.code.findbugs</groupId>
            <artifactId>annotations</artifactId>
            <version>3.0.0</version>
            <scope>provided</scope>
        </dependency>

[imod]

@Casz probably some ancient stuff - don't think its used anymore

[jetersen]

It's like a gift that just give on giving 😆

[jetersen]

hmm need some exclusion magic instead... meaning I need to open my IDE i'll do it later this in the evening

[jetersen]

I have Allow edits from maintainers if you feel like fixing it @imod 🙇

[imod]

I might be able to fix it in the later afternoon - let's see...

[jetersen]

Hmm seems like a bug tbh

Jenkins core uses commons-io 2.4
Yet maven interceptors is using newer...
https://github.com/jenkinsci/maven-interceptors/blob/master/pom.xml
so is org.apache.maven.shared:maven-shared-utils
perhaps updating Jenkins Core might align the version?

[imod]

sure we can - I don't mind

[jglick]

maven interceptors

Oof, I thought we were using that stuff only in maven-plugin hell…?

[jetersen]

🤷‍♂ The mavenSettingsMustBeFoundInFreestyleProject test passes locally.

[jetersen]

Seems like a super flaky test.

[imod]

@Casz the test case is quite ok, its actually an infrastructure issue - a required plugin could not been downloaded:

Plugin org.apache.maven.plugins:maven-clean-plugin:2.4.1 or one of its dependencies could not be resolved: Could not transfer artifact org.apache.maven.plugins:maven-clean-plugin:jar:2.4.1 from/to central (http://repo1.maven.org/maven2): Error transferring file: Server returned HTTP response code: 501 for URL: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.4.1/maven-clean-plugin-2.4.1.jar -> [Help 1]

[imod]

@Casz ah, for some reason it tries to download the maven-clean-plugin via http from maven-central and thats not supported by sonatype anymore - but to be honest, I have no idea why this is the case, I guess this should be fixed by some infrastructure (it seems not to be caused by the parent: https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/plugin/3.56/)

[jetersen]

Could we disable the test for now? As I know it works locally 🤔

[imod]

@Casz yes we can - I'm about to look into it. It seems to be related to the maven build which is triggered by the test case it self. For some reason the maven build triggered by the test case uses http instead of https - but that uses some internal stuff I have never looked at. ...I'm on it, you can disable the test for now.

[imod]

I'm able to reproduce the issue when I do this:

mv ~/.m2/repository/org/apache/maven/plugins ~/.m2/repository/org/apache/maven/plugins_old
mvn verify

[imod]

@Casz I fixed the issue with maven and http/https, but now it fails with an other error I don't quite understand yet - locally its still working fine

[jetersen]

Seems it just failed because channel closed too early: https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fconfig-file-provider-plugin/detail/PR-76/11/pipeline#log-950

[jetersen]

poking CI

[jetersen]

@imod seems we have a green build 🙇

[imod]

yeah, let's get this in then... - thanks!!