Refresh plugin build #90
Conversation
| @@ -43,11 +46,7 @@ | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-compiler-plugin</artifactId> | |||
| <version>3.9.0</version> | |||
There was a problem hiding this comment.
The version is defined in the plugin parent POM.
| <revision>1.21</revision> | ||
| <changelist>-SNAPSHOT</changelist> | ||
| <jenkins.version>2.332.1</jenkins.version> | ||
| <java.level>8</java.level> |
There was a problem hiding this comment.
This is highest java.level currently supported by the Jenkins project build infrastructure.
| <changelist>-SNAPSHOT</changelist> | ||
| <jenkins.version>2.332.1</jenkins.version> | ||
| <java.level>8</java.level> | ||
| <gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo> |
| <source>11</source> | ||
| <target>11</target> | ||
| <release>11</release> |
There was a problem hiding this comment.
These values are defined in the plugin parent POM.
| <plugin> | ||
| <groupId>org.jenkins-ci.tools</groupId> | ||
| <artifactId>maven-hpi-plugin</artifactId> | ||
| <version>3.22</version> | ||
| <configuration> | ||
| <minimumJavaVersion>11</minimumJavaVersion> | ||
| </configuration> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.codehaus.mojo</groupId> | ||
| <artifactId>animal-sniffer-maven-plugin</artifactId> | ||
| <version>1.21</version> | ||
| <configuration> | ||
| <signature> | ||
| <groupId>org.codehaus.mojo.signature</groupId> | ||
| <artifactId>java17</artifactId> | ||
| <version>1.0</version> | ||
| </signature> | ||
| </configuration> | ||
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>check</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| </plugin> |
There was a problem hiding this comment.
This configuration is defined in the plugin parent POM.
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>script-security</artifactId> | ||
| <version>1.78</version> |
There was a problem hiding this comment.
Version number defined in plugin BOM.
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>mailer</artifactId> | ||
| <version>412.v7deeda_155287</version> |
There was a problem hiding this comment.
Version number defined in plugin BOM.
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>token-macro</artifactId> | ||
| <version>267.vcdaea6462991</version> |
There was a problem hiding this comment.
Version number defined in plugin BOM.
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | ||
| <artifactId>workflow-step-api</artifactId> | ||
| <version>625.v2e7cf5fc4211</version> |
There was a problem hiding this comment.
Version number defined in plugin BOM.
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>structs</artifactId> | ||
| <version>308.v852b473a2b8c</version> |
There was a problem hiding this comment.
Version number defined in plugin BOM.
|
Thanks @basil for this PR! |
#87 was not correct. As long as the Jenkins project has not dropped support for Java 8, plugins need to be built with
<release>8</release>, as defined in the plugin parent POM.