Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plugin from 4.31 to 4.37 #74

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 24, 2022

Bumps plugin from 4.31 to 4.37.

Release notes

Sourced from plugin's releases.

4.37

馃摝 Dependency updates

4.36

馃悰 Bug fixes

馃摝 Dependency updates

4.35

馃毃 Removed

馃摝 Dependency updates

4.34

馃殌 New features and improvements

馃摝 Dependency updates

4.33

馃殌 New features and improvements

  • Bump Jenkins version to 2.249; clean up plugin parent POM (#480) @鈥媌asil

... (truncated)

Commits
  • f8cf435 [maven-release-plugin] prepare release plugin-4.37
  • c5a6200 Bump maven-hpi-plugin from 3.24 to 3.25 (#509)
  • e642011 [maven-release-plugin] prepare for next development iteration
  • 1127589 [maven-release-plugin] prepare release plugin-4.36
  • 249b41f Bump maven-hpi-plugin from 3.23 to 3.24
  • ec2cef6 Merge pull request #506 from MarkEWaite/avoid-maven-3.10.0-bug
  • 8cf69ef Avoid MCOMPILER-485 in compiler plugin 3.10.0
  • cc65412 [maven-release-plugin] prepare for next development iteration
  • 2acb388 [maven-release-plugin] prepare release plugin-4.35
  • 2918004 Bump jenkins-test-harness from 1705.va_296493db_feb_ to 1706.v5257fc59612a_ (...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@jtnord
Copy link
Member

jtnord commented Feb 25, 2022

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.jenkins-ci.plugins-plugin-4.37 branch from 9ebfe3e to 9a6a782 Compare February 25, 2022 14:21
@jtnord
Copy link
Member

jtnord commented Feb 25, 2022

[2022-02-25T14:24:26.152Z] [ERROR]   symbol:   class NonNull
[2022-02-25T14:24:26.152Z] [ERROR]   location: class jenkins.bouncycastle.api.PEMEncodable
[2022-02-25T14:24:26.152Z] [ERROR] /C:/Jenkins/workspace/ns_bouncycastle-api-plugin_PR74/src/main/java/jenkins/bouncycastle/api/PEMEncodable.java:[103,27] cannot find symbol
[2022-02-25T14:24:26.152Z] [ERROR]   symbol:   class NonNull
[2022-02-25T14:24:26.152Z] [ERROR]   location: class jenkins.bouncycastle.api.PEMEncodable

private PEMEncodable(@NonNull Object pemObject) {
this.object = pemObject;
}
using the spotbugs versions import edu.umd.cs.findbugs.annotations.NonNull

@basil given we are by default running spotbugs - I would not expect to have to add the spotbugs annotations myself in any plugin (this in the 3rd time I have not hit this issue) - esp as spotbugs (and previously findbugs) where added in the dependencies with the correct scope. (I would expect several more issues now where people bundle the annotations incorrectly).
I beleive this is caused by jenkinsci/plugin-pom#480 as the spotbugs dependency is incorrectly a non provided dependency in recent core versions code so the pom only works with those versions of core (wheras it should be version agnostic)

@jtnord
Copy link
Member

jtnord commented Feb 25, 2022

@dependabot rebase

Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.31 to 4.37.
- [Release notes](https://github.com/jenkinsci/plugin-pom/releases)
- [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/plugin-pom@plugin-4.31...plugin-4.37)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/org.jenkins-ci.plugins-plugin-4.37 branch from 9a6a782 to 8981a83 Compare February 25, 2022 14:42
@jtnord jtnord merged commit c85c02a into master Feb 28, 2022
@dependabot dependabot bot deleted the dependabot/maven/org.jenkins-ci.plugins-plugin-4.37 branch February 28, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant