Bump Jenkins version to 2.249; clean up plugin parent POM #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
force-pushed
the
cleanup
branch
2 times, most recently
from
ede3804
to
3bba424
Compare
basil
commented
Dec 26, 2021
Comment on lines
-234
to
-245
| <dependency> | ||
| <groupId>com.github.spotbugs</groupId> | ||
| <artifactId>spotbugs-annotations</artifactId> | ||
| <scope>provided</scope> | ||
| <optional>true</optional> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>com.google.code.findbugs</groupId> | ||
| <artifactId>jsr305</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> |
There was a problem hiding this comment.
As of 2.249, jenkins-core (which we depend on above) already depends on spotbugs-annotations transitively, so this is redundant. Furthermore, it causes Enforcer errors because of Maven's "nearest definition" algorithm. Better to remove it and have plugins get the version corresponding to their core baseline.
Comment on lines
-268
to
-280
| <dependency> | ||
| <groupId>org.kohsuke</groupId> | ||
| <artifactId>access-modifier-annotation</artifactId> | ||
| <scope>provided</scope> | ||
| <optional>true</optional> | ||
| <exclusions> | ||
| <exclusion> | ||
| <!-- provided by Jenkins core --> | ||
| <groupId>org.jenkins-ci</groupId> | ||
| <artifactId>annotation-indexer</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> |
There was a problem hiding this comment.
jenkins-core (which we depend on above) already depends on access-modifier-annotation transitively, so this is redundant. Furthermore, it causes Enforcer errors because of Maven's "nearest definition" algorithm. Better to remove it and have plugins get the version corresponding to their core baseline.
timja
approved these changes
Dec 28, 2021
jetersen
approved these changes
Dec 28, 2021
jglick
approved these changes
Dec 28, 2021
|
Feel free to release if you like. |
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements recent suggestions from the "annotation versions" mailing list thread.