Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump mailer from 1.34 to 391.ve4a_38c1b_cf4b_ in /bom-weekly #809

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Bump mailer from 1.34 to 391.ve4a_38c1b_cf4b_ in /bom-weekly #809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion bom-weekly/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>mailer</artifactId>
<version>1.34</version>
<version>391.ve4a_38c1b_cf4b_</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we shouldn鈥檛 be ending with an _?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃し as in jenkinsci/incrementals-tools#24 (comment) there are various occasions to avoid _ without triggering the misinterpretation as alpha / beta but I did not see a need to try too hard. Should be safe to make such refinements subsequently鈥攖he algorithm used is pinned to the extension version, which is part of the source tree, so there is still a deterministic version for a given commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah can probably just remove it if it鈥檚 ends in it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to refine logic after extending MainTest.alphaBeta to cover new cases.

</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
Expand Down