Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mina-sshd-api.version from 2.8.0-21.v493b_6b_db_22c6 to 2.8.0-30.vf9df64641cb_d in /bom-weekly #1275

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 18, 2022

Bumps mina-sshd-api.version from 2.8.0-21.v493b_6b_db_22c6 to 2.8.0-30.vf9df64641cb_d.
Updates mina-sshd-api-common from 2.8.0-21.v493b_6b_db_22c6 to 2.8.0-30.vf9df64641cb_d

Release notes

Sourced from mina-sshd-api-common's releases.

2.8.0-30.vf9df64641cb_d

🚀 New features and improvements

📦 Dependency updates

  • Bump bom-2.289.x from 1409.v7659b_c072f18 to 1466.v85a_616ea_b_87c (#14) @​dependabot
  • [chore] Fix deps management of modules that are in bom (#15) @​Dohbedoh
Commits

Updates mina-sshd-api-core from 2.8.0-21.v493b_6b_db_22c6 to 2.8.0-30.vf9df64641cb_d

Release notes

Sourced from mina-sshd-api-core's releases.

2.8.0-30.vf9df64641cb_d

🚀 New features and improvements

📦 Dependency updates

  • Bump bom-2.289.x from 1409.v7659b_c072f18 to 1466.v85a_616ea_b_87c (#14) @​dependabot
  • [chore] Fix deps management of modules that are in bom (#15) @​Dohbedoh
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jul 18, 2022
@dependabot dependabot bot requested a review from jglick July 18, 2022 22:34
@jglick
Copy link
Member

jglick commented Jul 19, 2022

@jetersen
Copy link
Member

@dependabot rebase

@jetersen jetersen added the developer Pull requests that merits a release for plugin developers label Jul 19, 2022
@dependabot dependabot bot force-pushed the dependabot/maven/bom-weekly/mina-sshd-api.version-2.8.0-30.vf9df64641cb_d branch from 5a64db5 to 7417337 Compare July 19, 2022 17:25
@jetersen
Copy link
Member

Forcing a release for developer

Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot squash and merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 19, 2022

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@jetersen
Copy link
Member

jetersen commented Jul 19, 2022

How to proceed @jglick @timja

Cycle detected: Plugin:sshd -> Plugin:mina-sshd-api-core -> Plugin:ssh-credentials -> Plugin:credentials -> Plugin:sshd

@jglick
Copy link
Member

jglick commented Jul 19, 2022

Uh, I guess we need a newer release of credentials? Really we would like to have an addition to split-plugin-cycles.txt in core but it is too late for that.

@timja
Copy link
Member

timja commented Jul 19, 2022

Uh, I guess we need a newer release of credentials? Really we would like to have an addition to split-plugin-cycles.txt in core but it is too late for that.

(you need to add an _ to the link, github breaks it)
https://github.com/jenkinsci/credentials-plugin/releases/tag/1074.v60e6c29b_b_44b_ uses 2.308, that would fix it if we drop 2.289 and 2.303.

Otherwise yeah we need a version of credentials newer backported a bit from around here possibly:
https://github.com/jenkinsci/credentials-plugin/blob/60e6c29bb44becfba2b37cc9aa1e49911bbb5816/pom.xml#L70

@jglick
Copy link
Member

jglick commented Jul 19, 2022

uses 2.308, that would fix it if we drop 2.289 and 2.303

Do we even have a problem on older lines to begin with?

Not that I am opposed to dropping some older lines if it is saving us significant work.

@jetersen
Copy link
Member

jetersen commented Jul 19, 2022

@timja FYI links with underscore a trick I learned for github will still convert the pretty link if you do something like this

[https://github.com/jenkinsci/credentials-plugin/releases/tag/1074.v60e6c29b_b_44b_](https://github.com/jenkinsci/credentials-plugin/releases/tag/1074.v60e6c29b_b_44b_)

https://github.com/jenkinsci/credentials-plugin/releases/tag/1074.v60e6c29b_b_44b_

@basil
Copy link
Member

basil commented Jul 19, 2022

I miss BBCode. No problems with underscores there!

@jetersen
Copy link
Member

@jglick FYI fixing the trailing underscore: jenkinsci/incrementals-tools#31 should not require changes elsewhere.

@jetersen
Copy link
Member

jetersen commented Jul 19, 2022

So backport or drop 2.289 and 2.303?

I feel like it is significantly old enough since they still have access to the currently released one once we drop it:

@timja
Copy link
Member

timja commented Jul 19, 2022

dropping is fine I think

@jetersen
Copy link
Member

Created #1289 for dropping

@jglick jglick mentioned this pull request Jul 20, 2022
6 tasks
@jetersen
Copy link
Member

@dependabot rebase

Bumps `mina-sshd-api.version` from 2.8.0-21.v493b_6b_db_22c6 to 2.8.0-30.vf9df64641cb_d.

Updates `mina-sshd-api-common` from 2.8.0-21.v493b_6b_db_22c6 to 2.8.0-30.vf9df64641cb_d
- [Release notes](https://github.com/jenkinsci/mina-sshd-api-plugin/releases)
- [Commits](https://github.com/jenkinsci/mina-sshd-api-plugin/commits)

Updates `mina-sshd-api-core` from 2.8.0-21.v493b_6b_db_22c6 to 2.8.0-30.vf9df64641cb_d
- [Release notes](https://github.com/jenkinsci/mina-sshd-api-plugin/releases)
- [Commits](https://github.com/jenkinsci/mina-sshd-api-plugin/commits)

---
updated-dependencies:
- dependency-name: io.jenkins.plugins.mina-sshd-api:mina-sshd-api-common
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.jenkins.plugins.mina-sshd-api:mina-sshd-api-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/bom-weekly/mina-sshd-api.version-2.8.0-30.vf9df64641cb_d branch from 7417337 to 7499e4a Compare July 21, 2022 09:11
@jetersen
Copy link
Member

@dependabot squash and merge

@jetersen jetersen removed the developer Pull requests that merits a release for plugin developers label Jul 21, 2022
@jetersen
Copy link
Member

ARGH

Cycle detected: Plugin:sshd -> Plugin:mina-sshd-api-core -> Plugin:ssh-credentials -> Plugin:credentials -> Plugin:structs -> Plugin:sshd

@jglick
Copy link
Member

jglick commented Jul 22, 2022

Well I can cut ssh-credentials releases if that is helpful. Is jenkinsci/ssh-credentials-plugin#140 useful for you in trunk? You want a backport branch from https://github.com/jenkinsci/ssh-credentials-plugin/releases/tag/277.v95c2fec1c047?

@jglick
Copy link
Member

jglick commented Jul 22, 2022

Feel free to use https://github.com/jenkinsci/ssh-credentials-plugin/commits/277.x as a PR target.

@jetersen
Copy link
Member

jenkinsci/ssh-credentials-plugin#140 is not mandatory. The blocker is

bom/bom-2.332.x/pom.xml

Lines 40 to 44 in 4bd09ff

<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>ssh-credentials</artifactId>
<version>277.v95c2fec1c047</version>
</dependency>

@jetersen
Copy link
Member

Okay looking at mina-sshd-api pom. It actually needs to pickup 2.319.x bom with ssh-credentials credential bom bump. Than the chain should be broken!

bom-2.319.x/pom.xml Outdated Show resolved Hide resolved
@@ -75,7 +76,8 @@
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>metrics</artifactId>
<version>4.1.6.1</version>
<!-- TODO https://github.com/jenkinsci/metrics-plugin/pull/175 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bom-weekly/pom.xml Show resolved Hide resolved
@jetersen
Copy link
Member

@dependabot cancel merge

bom-2.332.x/pom.xml Outdated Show resolved Hide resolved
@jetersen
Copy link
Member

All green 💚

bom-weekly/pom.xml Outdated Show resolved Hide resolved
bom-weekly/pom.xml Outdated Show resolved Hide resolved
bom-weekly/pom.xml Outdated Show resolved Hide resolved
@jetersen
Copy link
Member

superseded by #1332

@jetersen jetersen closed this Jul 26, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 26, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/bom-weekly/mina-sshd-api.version-2.8.0-30.vf9df64641cb_d branch July 26, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants