Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mailer from 1.34 to 391.ve4a_38c1b_cf4b_ in /bom-weekly #809

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 4, 2022

Bumps mailer from 1.34 to 391.ve4a_38c1b_cf4b_.

Release notes

Sourced from mailer's releases.

391.ve4a_38c1b_cf4b_

馃摝 Dependency updates

馃摑 Documentation updates

馃懟 Maintenance

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [mailer](https://github.com/jenkinsci/mailer-plugin) from 1.34 to 391.ve4a_38c1b_cf4b_.
- [Release notes](https://github.com/jenkinsci/mailer-plugin/releases)
- [Commits](https://github.com/jenkinsci/mailer-plugin/commits)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:mailer
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 4, 2022
@dependabot dependabot bot requested a review from jglick January 4, 2022 17:55
@basil basil enabled auto-merge (squash) January 4, 2022 17:55
@basil basil added the bug Something isn't working label Jan 4, 2022
@jglick
Copy link
Member

jglick commented Jan 4, 2022

So the plugin-pom bump in #777 did not reproduce the issues seen in e.g. jenkinsci/workflow-step-api-plugin#78, hmm.

@@ -260,7 +260,7 @@
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>mailer</artifactId>
<version>1.34</version>
<version>391.ve4a_38c1b_cf4b_</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we shouldn鈥檛 be ending with an _?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃し as in jenkinsci/incrementals-tools#24 (comment) there are various occasions to avoid _ without triggering the misinterpretation as alpha / beta but I did not see a need to try too hard. Should be safe to make such refinements subsequently鈥攖he algorithm used is pinned to the extension version, which is part of the source tree, so there is still a deterministic version for a given commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah can probably just remove it if it鈥檚 ends in it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to refine logic after extending MainTest.alphaBeta to cover new cases.

@basil basil merged commit b5ba455 into master Jan 4, 2022
@basil basil deleted the dependabot/maven/bom-weekly/org.jenkins-ci.plugins-mailer-391.ve4a_38c1b_cf4b_ branch January 4, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants