Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix jcasc test harness #69

Merged
merged 10 commits into from
Feb 8, 2020
Merged

fix jcasc test harness #69

merged 10 commits into from
Feb 8, 2020

Conversation

jetersen
Copy link
Member

@jetersen jetersen commented Jan 13, 2020

JCasc had to create a new dependency that wasn't a tests classifier because maven doesn't allow you to bring dependencies through classifiers.

Upgrading here so that PCT works again,

Tracking:
jenkinsci/bom#164

Note: We'll need a release for PCT please

@jetersen
Copy link
Member Author

damnmit ci.jenkins.io and your ClosedChannelException 😭

Copy link
Member

@gavinfish gavinfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot build successfully for the Rule 5: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps error. Need to upgrade some dependencies.

@jetersen
Copy link
Member Author

Like many of my other PRs 😓
I wonder why azure pipeline passes?

@gavinfish
Copy link
Member

Like many of my other PRs 😓
I wonder why azure pipeline passes?

The azure pipeline now only makes sure no secrets are exposed by accident. It will not build the project.

@jetersen
Copy link
Member Author

jetersen commented Feb 8, 2020

I created a separate PR for the last two commits.
You can choose to merge #73 first and than squash and merge this one.

Copy link
Member

@gavinfish gavinfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks @Casz

@gavinfish gavinfish merged commit 0ec1114 into jenkinsci:dev Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants