Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand test matrix by Java 11 #542

Closed
wants to merge 1 commit into from

Conversation

NotMyFault
Copy link
Member

The hosting requirements have been updated to ensure a plugin's minimum baseline tooling supports Java 11 too, alongside Java 8.

I'd like to see Java 11 added to the default Jenkinsfile, to promote Java 11 tests even further. New plugins should be tested against our Java baseline version too, by default, rather than just Java 8.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer configurations.

This change would double the load on ci.jenkins.io for new plugins, running every test four times. That is likely overkill; it is extremely rare for a test to fail on only one of these combinations. Typically I would pick Linux on JDK 11 and Windows on JDK 8.

At this point we should consider simply setting the Jenkins baseline to 2.361.x and thus requiring Java 11 for new plugins. @basil I think that would require maven.compiler.release and maven.compiler.testRelease to be overridden, right? It does not appear that any plugin using a 2.361.x or later dep is already doing this, which confuses me.

@jglick
Copy link
Member

jglick commented Nov 28, 2022

I think we never followed up on jenkinsci/plugin-pom#478 (comment).

@basil
Copy link
Member

basil commented Nov 28, 2022

@jglick
Copy link
Member

jglick commented Nov 28, 2022

Scratched my head mightily until I remembered jenkinsci/maven-hpi-plugin#323! So just using a new baseline automatically turns on a Java 11 requirement. I will prepare a PR accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants