fix jcasc test harness #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2020
Merged
jglick
approved these changes
Jan 13, 2020
| @@ -23,13 +23,13 @@ | |||
| <url>https://github.com/jenkinsci/${project.artifactId}-plugin</url> | |||
| <tag>HEAD</tag> | |||
| </scm> | |||
|
|
|||
There was a problem hiding this comment.
Please avoid gratuitous diff hunks.
There was a problem hiding this comment.
Please avoid gratuitous whitespace hunks 🗡 🤣
There was a problem hiding this comment.
Yes, the trailing spaces are unwanted, but if you feel the urge to clean up things like that it is best to do it in a separate PR explicitly claiming to have no semantic effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JCasc had to create a new dependency that wasn't a tests classifier because maven doesn't allow you to bring dependencies through classifiers.
Upgrading here so that PCT works again,
Tracking:
jenkinsci/bom#164
Note: We'll need a release for PCT please