Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade docker-fixtures from 1.11 to 1.12 #814

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Upgrade docker-fixtures from 1.11 to 1.12 #814

merged 3 commits into from
Jul 6, 2022

Conversation

basil
Copy link
Member

@basil basil commented Jul 6, 2022 •
edited by timja

Fixes #807

timja
timja approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NotMyFault NotMyFault added the dependencies Pull requests that update a dependency file label Jul 6, 2022
NotMyFault
NotMyFault approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a bunch 👏🏻

@timja
Copy link
Member

timja commented Jul 6, 2022 •
edited

core.FormValidationTest.validate

https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/PR-814/1/testReport/junit/core/FormValidationTest/java_11_jenkins_latest_split7___validate/

Appears to be a flakey test due to a timing issue with JavaScript, it passes sometimes, (and reliably passes when debugging 😉 )

I'll take a look

@timja
Stabilize FormValidationTest
650531a 
Current API is flawed for asserting form validation.
Matchers should be able to retrieve state from selenium, without knowing
what you are looking for you don't know what should be on the page.

Added a hacky sleep to stabilize test suite rather than adjusting the
API
@timja
Copy link
Member

timja commented Jul 6, 2022

I ran 650531a 6 times locally and it didn't fail, should be good enough for now

Filed #815 for a more comprehensive fix.

@timja timja enabled auto-merge (squash) July 6, 2022 22:17
@timja timja merged commit ef89e5c into jenkinsci:master Jul 6, 2022
@basil basil deleted the docker-fixtures branch July 6, 2022 23:20
jglick
jglick reviewed Jul 7, 2022
View reviewed changes
...main/resources/org/jenkinsci/test/acceptance/docker/fixtures/DockerAgentContainer/Dockerfile
@@ -1,4 +1,5 @@
FROM jenkins/java:d93654cc6239
# curl -s https://raw.githubusercontent.com/jenkinsci/docker-fixtures/master/src/main/resources/org/jenkinsci/test/acceptance/docker/fixtures/JavaContainer/Dockerfile | sha1sum | cut -c 1-12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a permalink (like a tag name).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request without reasoning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick left review comments

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Master branch build broken down to UnsupportedClassVersionError expectations of dependencies
4 participants
@basil @timja @jglick @NotMyFault