Add new feature which prints information about new plugins which can be upgraded to #611

jxr98 · 2021-08-13T15:34:22Z

Make sure that you've checked the boxes below before you submit PR:

Always

Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
Written well with PR title, we generate the release notes base on that

For the bug fixes or features only

LinuxSuRen

Failed when I try to compile this PR:

codespace ➜ /workspaces/jenkins-cli (pr/wxharry/610) $ gh pr checkout 611
remote: Enumerating objects: 41, done.
remote: Counting objects: 100% (41/41), done.
remote: Compressing objects: 100% (36/36), done.
remote: Total 36 (delta 26), reused 0 (delta 0), pack-reused 0
Unpacking objects: 100% (36/36), 8.79 KiB | 817.00 KiB/s, done.
From https://github.com/jenkins-zh/jenkins-cli
 * [new ref]         refs/pull/611/head -> plugincenter
Switched to branch 'plugincenter'
codespace ➜ /workspaces/jenkins-cli (plugincenter) $ make
go fmt ./util/...
go: github.com/creack/pty@v1.1.11: missing go.sum entry; to add it:
        go mod download github.com/creack/pty
make: *** [Makefile:108: fmt] Error 1

Still failed when I added the missing go.sum entry:

codespace ➜ /workspaces/jenkins-cli (plugincenter) $         go mod download github.com/creack/pty
codespace ➜ /workspaces/jenkins-cli (plugincenter ✗) $ make
go fmt ./util/...
go fmt ./client/...
go: downloading github.com/linuxsuren/http-downloader v0.0.22
go fmt ./app/...
go: downloading golang.org/x/text v0.3.5
go: downloading github.com/kevinburke/ssh_config v0.0.0-20190725054713-01f96b0aa0cd
go: downloading github.com/xanzy/ssh-agent v0.2.1
go: downloading github.com/sergi/go-diff v1.0.0
gofmt -s -w .
go vet ./...
go: downloading github.com/onsi/ginkgo v1.15.1
go: downloading github.com/onsi/gomega v1.11.0
app/cmd/plugin_center.go:9:2: missing go.sum entry for module providing package github.com/jedib0t/go-pretty/v6/table (imported by github.com/jenkins-zh/jenkins-cli/app/cmd); to add:
        go get github.com/jenkins-zh/jenkins-cli/app/cmd
/go/pkg/mod/github.com/google/go-github/v29@v29.0.3/github/git_commits.go:16:2: missing go.sum entry for module providing package golang.org/x/crypto/openpgp (imported by github.com/google/go-github/v29/github); to add:
        go get github.com/google/go-github/v29/github@v29.0.3
/go/pkg/mod/github.com/linuxsuren/go-cli-plugin@v0.0.4/pkg/cmd/fetch.go:7:2: missing go.sum entry for module providing package golang.org/x/crypto/ssh (imported by github.com/linuxsuren/go-cli-plugin/pkg/cmd); to add:
        go get github.com/linuxsuren/go-cli-plugin/pkg/cmd@v0.0.4
/go/pkg/mod/github.com/xanzy/ssh-agent@v0.2.1/sshagent.go:27:2: missing go.sum entry for module providing package golang.org/x/crypto/ssh/agent (imported by github.com/xanzy/ssh-agent); to add:
        go get github.com/xanzy/ssh-agent@v0.2.1
/go/pkg/mod/gopkg.in/src-d/go-git.v4@v4.13.1/plumbing/transport/ssh/auth_method.go:18:2: missing go.sum entry for module providing package golang.org/x/crypto/ssh/knownhosts (imported by gopkg.in/src-d/go-git.v4/plumbing/transport/ssh); to add:
        go get gopkg.in/src-d/go-git.v4/plumbing/transport/ssh@v4.13.1
/go/pkg/mod/github.com/jbenet/go-context@v0.0.0-20150711004518-d14ea06fba99/io/ctxio.go:16:2: missing go.sum entry for module providing package golang.org/x/net/context (imported by github.com/jenkins-zh/jenkins-cli/app/cmd); to add:
        go get github.com/jenkins-zh/jenkins-cli/app/cmd
/go/pkg/mod/gopkg.in/src-d/go-git.v4@v4.13.1/plumbing/transport/ssh/common.go:15:2: missing go.sum entry for module providing package golang.org/x/net/proxy (imported by gopkg.in/src-d/go-git.v4/plumbing/transport/ssh); to add:
        go get gopkg.in/src-d/go-git.v4/plumbing/transport/ssh@v4.13.1
/go/pkg/mod/github.com/mattn/go-isatty@v0.0.12/isatty_tcgets.go:6:8: missing go.sum entry for module providing package golang.org/x/sys/unix (imported by golang.org/x/term); to add:
        go get golang.org/x/term@v0.0.0-20210503060354-a79de5458b56
make: *** [Makefile:97: vet] Error 1

It works well when I try to run these commands:

codespace ➜ /workspaces/jenkins-cli (plugincenter ✗) $ go mod tidy
go: downloading github.com/jedib0t/go-pretty/v6 v6.2.3
go: downloading golang.org/x/net v0.0.0-20210226172049-e18ecbb05110
go: downloading golang.org/x/lint v0.0.0-20200302205851-738671d3881b
go: downloading honnef.co/go/tools v0.0.1-2020.1.3
go: downloading gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15
go: downloading golang.org/x/sys v0.0.0-20210616094352-59db8d763f22
go: downloading golang.org/x/tools v0.0.0-20210106214847-113979e3529a
go: downloading github.com/google/go-cmp v0.5.4
go: downloading github.com/mattn/go-runewidth v0.0.9
go: downloading github.com/kr/text v0.1.0
go: downloading github.com/golang/protobuf v1.4.3
go: downloading google.golang.org/protobuf v1.25.0
codespace ➜ /workspaces/jenkins-cli (plugincenter ✗) $ make
go fmt ./util/...
go fmt ./client/...
go fmt ./app/...
gofmt -s -w .
go vet ./...
export GO111MODULE=on
export GOPROXY=https://goproxy.io
go mod tidy
GO111MODULE=on CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags "-X github.com/linuxsuren/cobra-extension/version.version=dev-v0.0.37 -X github.com/linuxsuren/cobra-extension/version.commit=6474f76 -X github.com/linuxsuren/cobra-extension/version.date=2021-08-15" -o bin/linux/jcli main.go
chmod +x bin/linux/jcli
rm -rf jcli && ln -s bin/linux/jcli jcli

jxr98 · 2021-08-15T07:19:33Z

All right. I am gonna fix this.

LinuxSuRen · 2021-08-15T07:50:25Z

go.mod

@@ -1,6 +1,6 @@
 module github.com/jenkins-zh/jenkins-cli

-go 1.16
+go 1.14


why you change the go version here?

Oops, I've changed it back.

codecov-commenter · 2021-08-22T12:34:32Z

Codecov Report

Merging #611 (1ba6052) into master (a99158f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   37.98%   37.98%           
=======================================
  Files          13       13           
  Lines         416      416           
=======================================
  Hits          158      158           
  Misses        246      246           
  Partials       12       12

Flag	Coverage Δ
unittests	`37.98% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99158f...1ba6052. Read the comment docs.

LinuxSuRen · 2021-08-30T07:50:47Z

hi @jxr98 Please pay attention to the conflicts.

jxr98 · 2021-09-22T06:52:52Z

Hi @LinuxSuRen, I've solved the conflicts. By the way, any problem with this pr?

jxr98 · 2021-10-08T12:44:09Z

To use this new feature, a plugin called 'pipeline restful api' needs to be installed in jenkins. I've tested using the command './jcli plugin center'. It's a bit slow because the function is going to check every installed plugins in 'https://plugins.jenkins.io/api/plugin/'. The function only prints information about plugins which have newer versions then the installed.

jxr98 · 2021-10-11T12:18:57Z

Hello Rick. This pr is the second needed to be reviewed.

LinuxSuRen requested changes Aug 15, 2021

View reviewed changes

LinuxSuRen reviewed Aug 15, 2021

View reviewed changes

jxr98 changed the title ~~Add new feature which prints information about new plugins which can be upgraded to~~ WIP: Add new feature which prints information about new plugins which can be upgraded to Aug 15, 2021

jxr98 changed the title ~~WIP: Add new feature which prints information about new plugins which can be upgraded to~~ Add new feature which prints information about new plugins which can be upgraded to Aug 15, 2021

LinuxSuRen added conflicts feature labels Aug 30, 2021

jxr98 force-pushed the plugincenter branch 3 times, most recently from a577203 to aaa9027 Compare September 3, 2021 13:28

jxr98 mentioned this pull request Sep 6, 2021

Add new feature to create yaml including jenkins core and plugins and give users a choice to choose #620

Merged

10 tasks

jxr98 and others added 7 commits September 23, 2021 15:58

add -tail to job log

a3d0b93

Update job_log.go

fc8199c

Create plugin_center.go

e5eafb8

Update go.mod

dd0e81b

add error warning when using plugin center

b97cc42

update go.mod and go.sum

ec80c25

update go.sum

8eaf421

jxr98 force-pushed the plugincenter branch from 329c99b to 8eaf421 Compare September 23, 2021 08:11

modify go.mod and go.sum

80b084b

jxr98 force-pushed the plugincenter branch from 96137ba to f4c544a Compare September 23, 2021 09:20

modify go.mod and go.sum

5765151

jxr98 force-pushed the plugincenter branch from f4c544a to 5765151 Compare September 23, 2021 09:29

jxr98 changed the title ~~Add new feature which prints information about new plugins which can be upgraded to~~ WIP: Add new feature which prints information about new plugins which can be upgraded to Sep 24, 2021

modify go.mod and go.sum

1ba6052

jxr98 changed the title ~~WIP: Add new feature which prints information about new plugins which can be upgraded to~~ Add new feature which prints information about new plugins which can be upgraded to Sep 28, 2021

LinuxSuRen removed the conflicts label Sep 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new feature which prints information about new plugins which can be upgraded to #611

Add new feature which prints information about new plugins which can be upgraded to #611

jxr98 commented Aug 13, 2021

LinuxSuRen left a comment •

edited

jxr98 commented Aug 15, 2021

LinuxSuRen Aug 15, 2021

jxr98 Aug 15, 2021

codecov-commenter commented Aug 22, 2021 •

edited by codecov bot

LinuxSuRen commented Aug 30, 2021

jxr98 commented Sep 22, 2021

jxr98 commented Oct 8, 2021

jxr98 commented Oct 11, 2021

Add new feature which prints information about new plugins which can be upgraded to #611

Are you sure you want to change the base?

Add new feature which prints information about new plugins which can be upgraded to #611

Conversation

jxr98 commented Aug 13, 2021

Always

For the bug fixes or features only

LinuxSuRen left a comment • edited

Choose a reason for hiding this comment

jxr98 commented Aug 15, 2021

LinuxSuRen Aug 15, 2021

Choose a reason for hiding this comment

jxr98 Aug 15, 2021

Choose a reason for hiding this comment

codecov-commenter commented Aug 22, 2021 • edited by codecov bot

Codecov Report

LinuxSuRen commented Aug 30, 2021

jxr98 commented Sep 22, 2021

jxr98 commented Oct 8, 2021

jxr98 commented Oct 11, 2021

LinuxSuRen left a comment •

edited

codecov-commenter commented Aug 22, 2021 •

edited by codecov bot