Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables cd permissions for plugin-signpath #3900

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

paulsavoie
Copy link
Contributor

@paulsavoie paulsavoie commented Apr 26, 2024

Link to GitHub repository

https://github.com/jenkinsci/signpath-plugin

If you are modifying the release permission of your plugin or component, fill out the following checklist:

Release permission checklist (for submitters)

Edit tasklist title
Beta Give feedback Tasklist Release permission checklist (for submitters), more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to accounts.jenkins.io.
    Options
  2. All users added have logged in to Artifactory and Jira once.
    Options
  3. I have mentioned an existing team member of the plugin or component team to approve this request.
    Options

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Link to the PR enabling CD in your plugin

In this PR

CD checklist (for submitters)

Edit tasklist title
Beta Give feedback Tasklist CD checklist (for submitters), more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. I have provided a link to the pull request in my plugin, which enables CD according to the documentation.
    Options

Reviewer checklist

Edit tasklist title
Beta Give feedback Tasklist Reviewer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Check that the $pluginId Developers team has Admin permissions while granting the access.
    Options
  2. In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
    Options
  3. If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.
    Options

There are IRC Bot commands for it.

@paulsavoie paulsavoie requested a review from a team as a code owner April 26, 2024 08:54
@NotMyFault
Copy link
Member

You forgot to fill out the PR template.

@paulsavoie
Copy link
Contributor Author

You forgot to fill out the PR template.

Hello, sorry for the late reply, the message got lost on me. I don't understand the template. All I want to do is enabled the automated releases. It says to reference the PR that is performing this change. From my understanding, this very PR that I am commenting on is the one.

@timja
Copy link
Member

timja commented May 16, 2024

It should be a PR in this repository for making the Maven and GitHub workflow changes required:
https://github.com/jenkinsci/signpath-plugin

see
https://www.jenkins.io/doc/developer/publishing/releasing-cd/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants