feat(publishReports): add failIfEmpty parameter
#853
Conversation
Can you revert this change please? having this particular operations ( |
| lineCount=$(wc -l "${filename}" | awk '{print $1}') | ||
| if [[ "${failIsEmpty}" != false && "${lineCount}" -eq 0 ]]; then | ||
| echo "ERROR: ${filename} is empty." | ||
| exit 1 |
There was a problem hiding this comment.
Fundamental question: do we want the calling pipeline to fail? At first sight it looks like but since the only known use case today is jenkins-infra/helpdesk#4056 then I'm asking.
Is the condition (and its maintenance burden: it is not even tested since it is implemented with shell code) worth the gain considering PHS reports are now always generated?
There was a problem hiding this comment.
So... rename this PR and change failIfEmpty by skipIfEmpty?
I propose to remove the |
This PR adds an optional
failIfEmptyparameter to fail the call topublishReportsif the file to upload is empty. (To avoid erasing an existing report for example).The value of this parameter is set to false by default to keep the current behavior for existing consumers not needing it.
This PR also regroups the two
shblocks into one, and adds braces & double quotes around variables to prevent globbing and words splitting.Ref: