feat(terraform) Remove parameter agentContainerImage in favor of agentLabel
#817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduportal
reviewed
Jan 3, 2024
dduportal
reviewed
Jan 9, 2024
smerle33
added a commit
to jenkins-infra/azure
that referenced
this pull request
Jan 10, 2024
⚠️ DO NOT MERGE⚠️
|
need to update https://github.com/jenkins-infra/shared-tools/tree/main/terraform#jenkins-pipeline to document changes |
smerle33
force-pushed
the
agent/to/arm64
branch
from
5281b2f
to
6e1dc28
Compare
smerle33
changed the title
|
using this PR to test on AZURE : https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/PR-575 |
smerle33
force-pushed
the
agent/to/arm64
branch
from
26fd904
to
acce4ab
Compare
dduportal
reviewed
Jan 18, 2024
smerle33
added a commit
to jenkins-infra/shared-tools
that referenced
this pull request
Jan 19, 2024
…rary#817 as per jenkins-infra/helpdesk#3823 (comment) changing to AgentLabel
|
followed by jenkins-infra/shared-tools#136 to update documentation |
smerle33
changed the title
smerle33
changed the title
dduportal
changed the title
agentContainerImage in favor of agentLabel
dduportal
approved these changes
Jan 19, 2024
smerle33
added a commit
to jenkins-infra/shared-tools
that referenced
this pull request
Jan 19, 2024
chore(terraform): update documentation for jenkins-infra/pipeline-library#817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change in the pipeline shared library to start using labelled arm64 agent instead of PodTemplate
as per jenkins-infra/helpdesk#3823 (comment)