Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retrive only the last "next" draft release id #380

Merged
merged 4 commits into from May 16, 2022
Merged

fix: retrive only the last "next" draft release id #380

merged 4 commits into from May 16, 2022

Conversation

lemeurherve
Copy link
Member

Fixes #379

@lemeurherve lemeurherve requested a review from a team as a code owner May 14, 2022 12:39
dduportal
dduportal previously approved these changes May 14, 2022
View reviewed changes
@lemeurherve lemeurherve marked this pull request as draft May 14, 2022 12:49
@lemeurherve lemeurherve marked this pull request as ready for review May 14, 2022 13:55
@lemeurherve lemeurherve enabled auto-merge (squash) May 14, 2022 13:56
@dduportal dduportal added the bug label May 16, 2022
@lemeurherve lemeurherve merged commit fff4c73 into master May 16, 2022
@lemeurherve lemeurherve deleted the lemeurherve-patch-1 branch May 16, 2022 06:34
@jglick
Copy link
Contributor

jglick commented May 16, 2022

I wonder if this also affects jenkins-maven-cd-action.

@dduportal
Copy link
Contributor

I wonder if this also affects jenkins-maven-cd-action.

Interesting: is your comment about the fact that jenkins-maven-cd-action could use this library, or is it about the root problem (handling presence of multiple next releases)?

@jglick
Copy link
Contributor

jglick commented May 16, 2022

I am guessing that the code here was copied from https://github.com/jenkins-infra/jenkins-maven-cd-action/blob/a0a2c865bf13c0937b93d3190ed128af1bab2947/run.sh#L11 so I was wondering whether an analogous problem affected CD workflows. Do not recall offhand. CC @timja

@dduportal
Copy link
Contributor

As far as I remember, this code was written by @garethjevans , so yep, smells like same source 🤗

lemeurherve added a commit that referenced this pull request May 16, 2022
@lemeurherve
fix: correct jq expression to retrieve last next release draft
a3c05e9 
Follow-up of #380 

The previous one was retrieving the last release #, not always in draft nor titled "next"
@lemeurherve lemeurherve mentioned this pull request May 16, 2022
Merged
@lemeurherve
Copy link
Member Author

lemeurherve commented May 16, 2022 •
edited

I am guessing that the code here was copied from jenkins-infra/jenkins-maven-cd-action@a0a2c86/run.sh#L11 so I was wondering whether an analogous problem affected CD workflows. Do not recall offhand. CC @timja

I've proposed a fix here with the correct jq expression

This was referenced May 16, 2022
Merged
Open
lemeurherve added a commit to lemeurherve/pipeline-library that referenced this pull request Jun 1, 2022
@lemeurherve @lemeurherveCB
fix: retrive only the last "next" draft release id (jenkins-infra#380)
06b983d
smerle33 pushed a commit to smerle33/pipeline-library that referenced this pull request Jan 16, 2024
@lemeurherve @smerle33
fix: retrive only the last "next" draft release id (jenkins-infra#380)
81f1d07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

buildDockerAndPublishImage fails at GitHub Release stage if there are more than one "next" draft releases
3 participants
@lemeurherve @jglick @dduportal