Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated upload to unused blob storage in publishReports #855

Open
lemeurherve opened this issue May 6, 2024 · 0 comments
Open
Labels

Comments

@lemeurherve
Copy link
Member

lemeurherve commented May 6, 2024

Reproduction steps

  1. Observe
    // Blob container can be removed once files are uploaded on the azure file storage
    sh 'az storage blob upload --account-name=prodjenkinsreports --container=reports --timeout=${TIMEOUT} --file=${FILENAME} --name=${FILENAME} ${UPLOADFLAGS} --overwrite'
    // `az storage file upload` doesn't support file uploaded in a remote directory that doesn't exist but upload-batch yes. Unfortunately the cli syntax is a bit different and requires filename and directory name to be set differently.
    sh 'az storage file upload-batch --account-name prodjenkinsreports --destination reports --source ${SOURCE_DIRNAME} --destination-path ${DESTINATION_PATH} --pattern ${PATTERN} ${UPLOADFLAGS}'
  2. Notice the report is uploaded to both a blob storage and a file share (in the same prodjenkinsreports storage account).
  3. Notice the file share is the only one publicly exposed for consumption: https://github.com/jenkins-infra/kubernetes-management/blob/04f400e202bde38e443817e51da1bc809a1a0d22/config/reports.yaml#L8-L26

Expected Results

Report is uploaded only to the file share.

Actual Results

Report is uploaded to both the blob storage and the file share.

Anything else?

An helpdesk issue to delete the blob storage should be open after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant