New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark mode #7266
base: master
Are you sure you want to change the base?
Add dark mode #7266
Conversation
Fixes #6222 Some testing needed for all the sites that reuse jenkins.io styles (accounts, plugins, updates, stories) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dark mode looks really good on jenkins.io and appears to be consistent through the site.
Raised jenkins-infra/jenkins-io-components#146 to look into how we can share CSS vars across the various Jenkins sites - open to any ideas. |
|
Fixes #6222
This MR adds a dark theme for the site, following the user's system preference. I've widened our usage of CSS variables throughout the codebase so that colours should automatically adapt, I may have missed some so do let me know if you spot something that looks off.
I've went through the majority of pages and they're looking correct, I've highlighted current issues below:
Potential issues
Logos on the homepage are hard to read in dark modeHad to recreate the OSL logo by hand as I couldn't find an available SVG online - happy to contact them to see if they have one however