Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark theme #6222

Open
vitaly-zdanevich opened this issue Mar 30, 2023 · 12 comments · May be fixed by #7266
Open

Add dark theme #6222

vitaly-zdanevich opened this issue Mar 30, 2023 · 12 comments · May be fixed by #7266

Comments

@vitaly-zdanevich
Copy link

vitaly-zdanevich commented Mar 30, 2023

Suggestion

By using https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

@PrathamAditya
Copy link
Contributor

I want to know if this issue the part of someone's Gsoc project or not because last time commented on an issue related to footer enchantment guy opened it as a part of Gsoc project.

@krisstern
Copy link
Member

krisstern commented Apr 3, 2023

Hi @PrathamAditya I believe there is some misunderstanding. We have not selected the proposals for GSoC yet, so the issue you were referring to while is related to GSoC it was not for anyone’s GSoC project. Just wanted to clarify this. While GSoC is important for open-source, it is not more important than open-source. So in that spirit, feel free to contribute in your own capacity. That would definitely benefit the community a lot.

@Vandit1604
Copy link
Contributor

Hey i would like to work on this issue. I would like to make sure somebody is not working on this already.

@akoolarni
Copy link

I want to contribute for this issue. Please assign this to me.

@zbynek
Copy link
Contributor

zbynek commented Nov 8, 2023

This is in progress: jenkins-infra/plugin-site#1556
jenkins-infra/jenkins-io-components#110
jenkins-infra/gatsby-plugin-jenkins-layout#24
With these pull requsests it should be possible to have dark mode for the plugin site. The next step would then be moving the style from plugin site repo to this one and enabling it on all the Jenkins sites (main site -- this repo, stories, accounts, updates, ...).
After some bad experience with design changes from the main site affecting all the other sites I think this is the safe approach.

@akoolarni maybe when plugin site is ready you can take over this effort? Issues are generally never assigned, so just let people know that you're working on it.

@akoolarni
Copy link

@zbynek Thankyou! Till when can the plugin site be ready?

@krisstern
Copy link
Member

krisstern commented Nov 9, 2023

@akoolarni Your best bet would be to follow the PR jenkins-infra/plugin-site#1556 closely to see when it is merged. Once it is merged it should be ready to go.

@akoolarni
Copy link

Sure, that would work. Thank you 👍

@akoolarni
Copy link

Till then, can I work on some other issue please. It would mean a lot of you help me figuring the same. I will do the best I can.

@zbynek
Copy link
Contributor

zbynek commented Jan 6, 2024

@akoolarni if you're still interested, the PR for the plugin site was merged, so now you can start working on this.

@akoolarni
Copy link

Yes, I am interested to contribute.

@akoolarni
Copy link

Will make a PR soon.
Almost solved the issue.

@zbynek zbynek linked a pull request Apr 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants