Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use modern syntax for altDeploymentLocation #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jtnord
Copy link

@jtnord jtnord commented Apr 17, 2023

when performing a CD release the build produces warnings about old formats for altDeploymentLocation

[INFO] --- maven-deploy-plugin:3.1.1:deploy (default-deploy) @ aws-java-sdk-parent ---
[INFO] Using alternate deployment repository maven.jenkins-ci.org::default::https://repo.jenkins-ci.org/releases/
[WARNING] Using legacy syntax for alternative repository. Use "maven.jenkins-ci.org::https://repo.jenkins-ci.org/releases/" instead.

This requires maven 3 (as noted by https://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html#altDeploymentRepository) - and there should IIUC be no need to support maven 2.

Note: In version 2.x, the format was id::layout::url where layout could be default (ie. Maven 2) or legacy (ie. Maven 1), but since 3.0.0 the layout part has been removed because Maven 3 only supports Maven 2 repository layout.

Note: this is completely untested but should fix #24

@jtnord jtnord changed the title use modern syntax for altDEploymentLocation use modern syntax for altDeploymentLocation Apr 17, 2023
@lemeurherve
Copy link
Member

@jtnord should someone review this PR?

LGTM but not really knowledgeable on the subject.

@jtnord
Copy link
Author

jtnord commented Sep 15, 2023

@jtnord should someone review this PR?

LGTM but not really knowledgeable on the subject.

Probably should, or you could YOLO :-)

@timja timja requested a review from jglick September 15, 2023 12:56
@jglick
Copy link
Contributor

jglick commented Sep 15, 2023

Should ideally be pretested in https://github.com/jenkinsci/jenkins-infra-test-plugin; I can try to do that if you do not feel up to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using legacy syntax for alternative repository
4 participants