Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize localization as trigger #20

Merged

Conversation

NotMyFault
Copy link
Member

@NotMyFault
Copy link
Member Author

@timja any plans how we want to proceed with this PR? This label would be the one I'd add to the default workflow.

@timja timja merged commit a0a2c86 into jenkins-infra:master May 6, 2022
@NotMyFault NotMyFault deleted the feat/master/recognize-localization branch May 6, 2022 07:04
@NotMyFault NotMyFault restored the feat/master/recognize-localization branch May 6, 2022 07:04
@NotMyFault NotMyFault deleted the feat/master/recognize-localization branch May 6, 2022 07:04
@jglick
Copy link
Contributor

jglick commented May 9, 2022

@timja do you recall if this configuration is even still used? jenkins-infra/interesting-category-action#4 is the relevant spot, I thought. In which case

if [ $GITHUB_EVENT_NAME = check_run ]
then
gh api /repos/$GITHUB_REPOSITORY/releases | jq -e -r '.[] | select(.draft == true and .name == "next") | .body' | egrep "$INTERESTING_CATEGORIES"
fi
and
INTERESTING_CATEGORIES:
required: true
description: |
Regexp of emojis from https://github.com/jenkinsci/.github/blob/master/.github/release-drafter.yml representing changes of interest to users.
By default excludes 📦📝👻🚦 under the assumption these do not normally merit a release.
Ignored when using workflow_dispatch (explicit release); when using the check_run trigger (automatic), the release is skipped unless the draft changelog matches.
default: '[💥🚨🎉🐛⚠🚀🌐👷]|:(boom|tada|construction_worker):'
could be deleted and
- run: GITHUB_TOKEN=${{ inputs.GITHUB_TOKEN }} MAVEN_USERNAME=${{ inputs.MAVEN_USERNAME }} MAVEN_TOKEN=${{ inputs.MAVEN_TOKEN }} INTERESTING_CATEGORIES='${{ inputs.INTERESTING_CATEGORIES }}' $GITHUB_ACTION_PATH/run.sh
amended? Or did you leave this clause for compatibility after introducing interesting-category-action?

@timja
Copy link
Member

timja commented May 9, 2022

I think it was for compatibility can't remember where the discussion at the time was though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants