Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ionicons to script set #253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add ionicons to script set #253

wants to merge 1 commit into from
+24 −4

Conversation

NotMyFault
Copy link
Member

Fixes #252

Looks (almost) as expected:

Screenshot 2023-03-28 at 21 16 26

@hervelemeur
Copy link

I would have expected this to be included and self-contained in jenkins-io-components.
If we need to add this kind of dependencies everywhere it kind of defeats the point of web components isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing exclamation mark in jio footer
2 participants
@NotMyFault @hervelemeur