Use web component for header and footer. Add extra links to header

[halkeye]

[timja]

The additional header links aren't very obvious to me

navigating with them feels strange, tbh I preferred the second nav bar more but maybe there's a better way to do it, thoughts?

[timja]

one of these changes causes a browser console error, I assume the version of bootstrap relies on this (even if we aren't using that)

[timja]

the ion-icon doesn't seem to be showing for me

[halkeye]

navigating with them feels strange, tbh I preferred the second nav bar more but maybe there's a better way to do it, thoughts?

Yea I can't think of anything better. I tried putting a divider in between, but it didn't look much better. It just felt weird.

Any idea what the old one looked like?

[timja]

Not sure what the original one did,

it's currently like:

which is far better than the broken one was that was in place for years

I wonder if it would work if you got rid of all the other links, (bar maybe one or two that take you to jenkins.io and plugin site)

[halkeye]

Oh I like that one. A simple flexbox or something. What I saw when I logged in was a broken collapse bar.

[timja]

played around with less links in this:

not sold on the separator but I think it needs something

Oh I like that one. A simple flexbox or something. What I saw when I logged in was a broken collapse bar.

I fixed it in the weekend, it was using bootstrap 3 classes, when jenkins.io had upgraded to bootstrap 4...

[dduportal]

jenkins-infra/docker-confluence-data#32 (review)

[lemeurherve]

Suggested change

	<script async="" data="jio" src="https://unpkg.com/@halkeye/jenkins-io-components?module" type="module" />
	<script async="" data="jio" nomodule="" src="https://unpkg.com/@halkeye/jenkins-io-components" />
	<script async="" data="jio" src="https://unpkg.com/@jenkinsci/jenkins-io-components?module" type="module" />
	<script async="" data="jio" nomodule="" src="https://unpkg.com/@jenkinsci/jenkins-io-components" />