Missing exclamation mark in jio footer

[NotMyFault]

Problem with this page

https://accounts.jenkins.io/login

Expected behavior

If you can report a problem with the page, the interface is prefixed with a warning symbol, as seen in the footer on plugins.jenkins.io for example.

Actual behavior

There's no warning symbol on accounts.j.io, which looks odd.

We're using the following couple of lines to place the footer:

account-app/src/main/resources/org/jenkinsci/account/taglib/layout.jelly

Lines 90 to 91 in 234f912

	<jio-footer id='footer' style="position:absolute; width:100%" property="https://accounts.jenkins.io"
	reportAProblemTemplate="1-bug.yml" githubRepo="jenkins-infra/account-app" githubBranch="main"></jio-footer>

@halkeye Is there anything in particular we need to add to ensure our footer interfaces look the same like on jenkins.io or plugins.jenkins.io?

Possible solution

No response

[halkeye]

Yea you probably need ion-icons which is not bundled. You can find them in Jenkins.io layout templates

[NotMyFault]

Yea you probably need ion-icons which is not bundled. You can find them in Jenkins.io layout templates

Thanks for the pointer, I thought they were bundled or something.

[halkeye]

Jenkins.ion has been using it independently before this so I choose to keep things smaller.

[NotMyFault]

Jenkins.ion has been using it independently before this so I choose to keep things smaller.

If they are needed for footer links, it would make sense to bundle them in jio components I'd say, no? jenkins.io uses ionicons on more occasions than the footer. Hence, they have been around longer, but for pages which don't use ionicons at all, jio bundling it sounds preferable to me.

[halkeye]

It would make the bundle size much bigger and then loaded twice.

I'm not against it just explaining what I was thinking

Could just be listed as explicit dependency or lazy loads from cdn if not found

[timja]

Can we bundle just the icon required? or just inline SVG?

[halkeye]

probably doable if someone wants to figure out how