Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require full screen on iOS #430

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cyberbeni
Copy link

@Cyberbeni Cyberbeni commented Apr 26, 2023

fixes #426
fixes #376

couldn't test it because the Expo Go app already supports split screen and couldn't figure out how to build the standalone app

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #430 (1f1547b) into master (ab29a3a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   60.21%   60.21%           
=======================================
  Files          46       46           
  Lines         945      945           
  Branches      189      189           
=======================================
  Hits          569      569           
  Misses        341      341           
  Partials       35       35           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anthonylavado anthonylavado self-requested a review May 1, 2023 15:47
@thornbill thornbill added the bug Something isn't working label May 24, 2023
@thornbill thornbill added this to the v1.6.0 milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't go fullscreen on external monitor Split screen does not work on iPadOS 15
2 participants