Add ability to direct play ass with exoplayer #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxr1998
added
enhancement
Maxr1998
requested changes
Sep 30, 2022
app/src/main/java/org/jellyfin/mobile/player/deviceprofile/DeviceProfileBuilder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/mobile/player/deviceprofile/DeviceProfileBuilder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/mobile/player/deviceprofile/DeviceProfileBuilder.kt
Outdated
Show resolved
Hide resolved
Maxr1998
approved these changes
Oct 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a check box in the client settings for ExoPlayer to enable direct play SSA/ASS subtitles without transcoding.
ExoPlayer only partially supports ass subtitles. While support for more features of ass is being worked on it currently only displays it as basic text. Because of that the Jellyfin Android app used to always transcode those subtitles when selected before starting playback. However some people may only have files with basic text in ass subtitles, not care about all the fancy styling or need to avoid transcoding because their server isn't that powerful. Therefore this PR adds the option to direct play ass subtitles.
Issues
#696
jellyfin/jellyfin#7809