[2.5-stable] Give simple color override instructions #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, encourage the use of the forward-compatible `minima/custom-styles` name for any changes beyond SCSS variables.
Looks like solidly not my fault. |
mattr-
reviewed
Dec 29, 2021
| // $background-color: #fdfdfd; | ||
| // $brand-color: #2a7ae2; | ||
| @import "minima"; | ||
| // Need more than just color changes? Fill out the _sass/minima/custom-styles.scss file. |
There was a problem hiding this comment.
Would you mind updating the comment here? I can't tell if the user needs to add _sass/minima/custom-styles.css to their site? Import it as in the example below? There's some text a couple of lines below that looks like it gives some additional instructions. Perhaps we should combine that one with this comment here?
There was a problem hiding this comment.
Yes, you add it as a new file to your site in addition to this.
|
What is about this change? |
|
I had big problem with brand-color override using GitHub Pages, and could do it only after reading readme from this abandoned PR 💔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, encourage the use of the forward-compatible
minima/custom-stylesname for any changes beyond SCSS variables.Context
See also jekyll/jekyll#8642, which will link to the 2.5-stable branch until the new version is promoted to stable.