Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.9-stable: allow Pages to be Excerpted #9550

Merged
merged 3 commits into from Feb 13, 2024

Conversation

parkr
Copy link
Member

@parkr parkr commented Feb 12, 2024

This is a 🙋 feature or enhancement.

Summary

This allows Excerpts to be created from Pages, rather than just from Documents.

Context

jekyll-relative-links started expecting Pages to work with excerpts in benbalter/jekyll-relative-links#65. When github-pages upgraded their version of that gem, it started causing anyone using that plugin to fail the build, see #9544.

I figure it's alright to give Pages the ability to have excerpts.

cc @yoannchaudet

@parkr parkr requested a review from a team February 12, 2024 22:06
@parkr parkr changed the base branch from master to 3.9-stable February 12, 2024 22:07
@parkr parkr marked this pull request as ready for review February 12, 2024 22:22
Copy link

@yoannchaudet yoannchaudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Just practiced upgrading all the things last week, I am all warm and ready to publish a new gem again when you cut a release!

@parkr parkr changed the title 3.9 stable excerpted pages 3.9-stable: allow Pages to be Excerpted Feb 13, 2024
@parkr
Copy link
Member Author

parkr commented Feb 13, 2024

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit ee86ce5 into 3.9-stable Feb 13, 2024
12 checks passed
@jekyllbot jekyllbot deleted the 3.9-stable-excerpted-pages branch February 13, 2024 04:19
jekyllbot added a commit that referenced this pull request Feb 13, 2024
@parkr parkr mentioned this pull request Feb 13, 2024
@parkr parkr added forward-port ⏩ backport-candidate Consider for merge into an older stable branch labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate Consider for merge into an older stable branch enhancement forward-port ⏩
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants