Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation.md #9384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

repo-reviews
Copy link

This is a 馃敠 documentation change.

  • I've adjusted the documentation (if it's a feature or enhancement)

Summary

I've modified the documentation to mention the requirement of a JavaScript runtime, an issue that arises when following the existing instructions.

Context

This issue was referenced by another user here: #2327 (comment)

The language I've used in the update reflects the language used in the error output (see first line of stacktrace in comment, copied below]. That language references execjs for a list of JavaScript runtimes:

/home/yze14/.rvm/gems/ruby-2.1.1/gems/execjs-2.0.2/lib/execjs/runtimes.rb:51:in `autodetect': Could not find a JavaScript runtime. See https://github.com/sstephenson/execjs for a list of available runtimes. (ExecJS::RuntimeUnavailable)

@parkr
Copy link
Member

parkr commented Aug 14, 2023

I see you're using Ruby 2.1.1 which is EOL. Is this necessary with ruby 3.2, today's latest version?

@repo-reviews
Copy link
Author

yes, I think it's still necessary because ruby 3.2 doesn't install a javascript runtime by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants