Revert "Optimize Site#each_site_file (#9187)"

[DavidS]

This reverts commit b2891a4.

This is a 🐛 bug fix.

Summary

Since #9187 static files from collections don't get written out anymore.

Context

My gallery plugin injects images and thumbnails to write out as static files into collections. With the optimization from #9187, they do not get rendered anymore. Either this revert, or adding collections.each_value { |coll| coll.files.each { |doc| yield(doc) if doc.write? } } fixes the issue for me.

[DavidS]

Updated to the second option I've found to avoid the performance impact that #9187 fixed

[ashmaroli]

Hello @DavidS
It's unfortunate that the released implementation doesn't play well with your plugin.

Theoretically, the change you have proposed (as per current diff) shouldn't be necessary because the static_files reference in ln#364 is supposed to be a real-time reference to all static files in the site, including those within collections.

So, the bug is either in Jekyll's site.static_files or in your generator plugin.

[shushugah]

This would have a lower cyclomatic complexity, what do you think?

 collections.each_value do  |coll| 
   if doc.write?
     coll.docs.each(&method(:yield))
     coll.files.each(&method(:yield)) 
  end
end