Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated windows.md #9288

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Updated windows.md #9288

wants to merge 1 commit into from

Conversation

Gyrohammer
Copy link

This is a 馃敠 documentation change.

Summary

I updated the ruby versions and gem update command.

Context

Ruby is now at v2.7.x and some of the packages (gems? New to ruby sorry) Jekyll uses are incompatible with 2.5. I removed 2.5 and installed 2.7 from the same repository listed in the doc. Jekyll then failed install since the latest sass-embedded wasnt supported on RubyGems 3.1.6. To update RubyGems I then had to run gem update --system which resolved the issue and let me install Jekyll. This was all performed on Windows 11 via WSL.

Updated versions for ruby and included new (?) gem update command.
@ashmaroli
Copy link
Member

I agree with you, @Gyrohammer.
Even though Jekyll Core codebase is totally compatible with Ruby 2.5, its dependencies need not be so.
Ruby 2.7 itself will be EOL in about 7 weeks. So people just starting out with Ruby / Jekyll tend to install more recent Ruby 3.1 and above.

Are there more changes incoming since you have this as a draft request..?

@Gyrohammer
Copy link
Author

Hey there! My apologies I've never contributed to a public project before and got cold feet! I thought a draft wouldnt publish but it did. I looked it up after the fact and saw that 2.7 is EOL, I wasnt aware before I published this. I wasnt planning to do anything more with this so the draft was just a mistake on my part, sorry for the confusion.

@ashmaroli
Copy link
Member

No worries, @Gyrohammer. The very first time is always filled with apprehensions. :)

Regarding the proposed changes, I think gem update --system wouldn't be necessary if the user is installing Ruby 3.1 or newer.
Will you be able to check and make changes here if necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants