Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update liquid gem to version 5 #8662

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update liquid gem to version 5 #8662

wants to merge 1 commit into from

Conversation

skatkov
Copy link

@skatkov skatkov commented May 4, 2021 •
edited

fixes #8615
fixes #8535

Unfortunately, liquid v5 is not backwards compatible with liquid 4 version - there are plenty of breaking changes.

And while I managed to loosen up dependency, it even compiles and deploys. I wonder what other issues can liquid gem update bring?

@skatkov skatkov marked this pull request as draft May 4, 2021 16:29
@skatkov skatkov changed the title loosen up liquid gem constraint (WIP) loosen up liquid gem constraint May 4, 2021
@skatkov skatkov changed the title (WIP) loosen up liquid gem constraint Update liquid gem to version 5 May 4, 2021
@DirtyF DirtyF requested review from a team, mattr- and ashmaroli and removed request for a team May 14, 2021 19:19
@DirtyF DirtyF added the breaking-change Affect current behavior label May 14, 2021
@DirtyF DirtyF added this to the 5.0 milestone May 14, 2021
@DirtyF DirtyF mentioned this pull request May 14, 2021
Closed
@SteveALee
Copy link

SteveALee commented Aug 10, 2021 •
edited

Is anyone working on this? We would really like to have have liquid 5.0.0 or at least {% liquid %} and {% echo %} to MASSIVELY simplify our code by eliminating the usual tag soup.

@ashmaroli
Copy link
Member

@SteveALee Liquid 5 has breaking changes. However, you are free to submit a new pull request complete with passing tests that ensures users do not face issues with the version bump.

@chmaynard
Copy link
Contributor

@SteveALee Liquid 5 has breaking changes. However, you are free to submit a new pull request ...

I guess that means no. :)

@SteveALee
Copy link

Hmmm :)

@parkr parkr mentioned this pull request Apr 10, 2022
Open
@isimluk isimluk mentioned this pull request Dec 25, 2022
Open
@invalidusrname invalidusrname mentioned this pull request Dec 30, 2022
Closed
@NUARI19
Copy link

NUARI19 commented Feb 28, 2023

fixes #8615 fixes #8535

Unfortunately, liquid v5 is not backwards compatible with liquid 4 version - there are plenty of breaking changes.

And while I managed to loosen up dependency, it even compiles and deploys. I wonder what other issues can liquid gem update bring?

skatkov:update-liquid-library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattr- mattr- Awaiting requested review from mattr-

@ashmaroli ashmaroli Awaiting requested review from ashmaroli

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking-change Affect current behavior
Projects
None yet
Milestone
5.0
6 participants
@skatkov @SteveALee @ashmaroli @chmaynard @NUARI19 @DirtyF