-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use official Ruby setup GH action #8614
Conversation
Oh I see some overlap with #8610. Will wait for that to merge first. |
Looks good but I see there are conflicts to fix and this is WIP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix conflicting file.
@MichaelCurrin yes you were right, the bundle env variables had to be declared at the job-level so that other steps use the correct bundle config! Thanks for pointing that out 馃槂 Given that the |
Yes good that the checks are passing. And the job is setup to run on a PR against master and will work the same once merged. |
You can find your branch marked with passing runs on the Actions tab |
Hi @MichaelCurrin, sorry I dropped the ball for a couple of weeks 馃槄 Is there some further action needed from me to push this PR forward? |
No PR changes are outstanding. This just needs a review and merging by a maintainer - a reviewer with write access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I wasn't able to fully validate the bundler-cache option but I'm assuming we'll be able to continue benefitting from the Actions cache.
More info on bundler cache flag here: https://github.com/ruby/setup-ruby#single-job That means that in this PR, we use the ruby/setup-ruby action to handle Bundle itself, bundle install step and cache of gems too. And so the cache action and the gem install steps are unnecessary and are good to be taken out. |
@jekyll: merge +dev |
This is a CI fix (housekeeping).
Summary
I noticed that the CI results in #8587 mentioned that
actions/setup-ruby
is no longer maintained and that we should migrate to usingruby/setup-ruby
instead.This PR updates jobs to use
ruby/setup-ruby
. I'm not super-familiar with Ruby and had to guess which steps were obsolete with the new action. Hopefully, the GH Actions results on this PR will help evaluate whether I got it right! 馃槄EDIT: Haha that didn't work. Will try debugging later this week.