Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce array allocations from StaticFile#path #8083

Merged
merged 3 commits into from Mar 30, 2020
Merged

Reduce array allocations from StaticFile#path #8083

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0204057
Reduce array allocations from `StaticFile#path`
ashmaroli Mar 30, 2020
d042e7a
Temporarily freeze the path attribute value
ashmaroli Mar 30, 2020
1f745a1
Revert "Temporarily freeze the path attribute value"
ashmaroli Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 7 additions & 5 deletions lib/jekyll/static_file.rb
View file
Open in desktop
Expand Up @@ -40,11 +40,13 @@ def initialize(site, base, dir, name, collection = nil)

# Returns source file path.
def path
# Static file is from a collection inside custom collections directory
if !@collection.nil? && !@site.config["collections_dir"].empty?
File.join(*[@base, @site.config["collections_dir"], @dir, @name].compact)
else
File.join(*[@base, @dir, @name].compact)
@path ||= begin
# Static file is from a collection inside custom collections directory
if !@collection.nil? && !@site.config["collections_dir"].empty?
File.join(*[@base, @site.config["collections_dir"], @dir, @name].compact)
else
File.join(*[@base, @dir, @name].compact)
end
end
end

Expand Down